Update app.py

app.py

@@ -1,9 +1,10 @@
 """
 LocaleNLP Translation Service
 ============================
+
 A multi-language translation application supporting English, Wolof, Hausa, and Darija.
 Features text, audio, and document translation with automatic chaining for all language pairs.
-Includes user feedback logging to CSV.
+
 Author: LocaleNLP
 """
 
@@ -15,8 +16,6 @@ from typing import Optional, Dict, Tuple, Any, Union
 from pathlib import Path
 from dataclasses import dataclass
 from enum import Enum
-import csv
-from datetime import datetime
 
 import gradio as gr
 import torch
@@ -27,7 +26,7 @@ from bs4 import BeautifulSoup
 from markdown import markdown
 import chardet
 from transformers import pipeline, MarianTokenizer, AutoModelForSeq2SeqLM
-from huggingface_hub import login, upload_file
+from huggingface_hub import login
 
 # ================================
 # Configuration & Constants
@@ -133,8 +132,7 @@ class ModelManager:
             logger.info(f"Loading translation model: {config.model_name}")
             
             # Authenticate with Hugging Face if token provided
-            hf_token = os.getenv("hffff")
-            if hf_token:
+            if hf_token := os.getenv("hffff"):
                 login(token=hf_token)
             
             model = AutoModelForSeq2SeqLM.from_pretrained(
@@ -468,72 +466,6 @@ class TranslationApp:
             
         return ""
     
-    def log_feedback(
-        self,
-        source_lang: Language,
-        target_lang: Language,
-        user_input: str,
-        model_output: str,
-        notation: Optional[float] = None,
-        correct_translation: Optional[str] = None
-    ):
-        """
-        Log user feedback to a CSV file and push to Hugging Face repo if running in Space.
-        """
-        # Define filename
-        src = source_lang.value.lower()
-        tgt = target_lang.value.lower()
-        filename = f"{src}_{tgt}.csv"
-    
-        headers = [
-            "timestamp",
-            "source_language",
-            "target_language",
-            "user_input",
-            "model_output",
-            "notation",
-            "correct_translation"
-        ]
-        row = {
-            "timestamp": datetime.now().isoformat(),
-            "source_language": source_lang.value,
-            "target_language": target_lang.value,
-            "user_input": user_input.strip(),
-            "model_output": model_output.strip(),
-            "notation": notation,
-            "correct_translation": correct_translation.strip() if correct_translation else ""
-        }
-    
-        file_exists = Path(filename).exists()
-    
-        try:
-            # Write to local CSV
-            with open(filename, mode="a", encoding="utf-8", newline="") as f:
-                writer = csv.DictWriter(f, fieldnames=headers)
-                if not file_exists:
-                    writer.writeheader()
-                writer.writerow(row)
-            logger.info(f"Feedback saved locally to {filename}")
-
-            # Try to push to HF repo if HF_TOKEN exists
-            hf_token = os.getenv("hffff")
-            space_id = os.getenv("SPACE_ID")  # e.g., "yourusername/your-space-name"
-            if hf_token and space_id:
-                try:
-                    upload_file(
-                        path_or_fileobj=filename,
-                        path_in_repo=filename,
-                        repo_id=space_id,
-                        token=hf_token,
-                        repo_type="space",
-                        commit_message=f"Add/update feedback: {filename}"
-                    )
-                    logger.info(f"Successfully pushed {filename} to Hugging Face Space repo.")
-                except Exception as e:
-                    logger.warning(f"Failed to push feedback to HF Hub: {e}")
-        except Exception as e:
-            logger.error(f"Failed to save feedback to {filename}: {e}")
-
     def create_interface(self) -> gr.Blocks:
         """Create and return the Gradio interface."""
         
@@ -604,35 +536,7 @@ class TranslationApp:
                 lines=10,
                 interactive=False
             )
-
-            # --- FEEDBACK SECTION ---
-            gr.Markdown("### 📝 Provide Feedback on Translation")
-
-            notation = gr.Slider(
-                minimum=1,
-                maximum=5,
-                step=1,
-                label="Rate translation quality (1-5 stars)",
-                value=None,
-                interactive=True
-            )
-
-            correct_translation = gr.Textbox(
-                label="Correct Translation (if incorrect)",
-                placeholder="Please provide the correct version if inaccurate...",
-                lines=4,
-                value=""
-            )
-
-            submit_feedback = gr.Button("📤 Submit Feedback", variant="primary")
-            feedback_status = gr.Textbox(label="Feedback Status", value="", interactive=False)
-
-            # Hidden states to preserve context for feedback
-            user_input_state = gr.State()
-            model_output_state = gr.State()
-            source_lang_state = gr.State()
-            target_lang_state = gr.State()
-
+            
             # Event handlers
             def update_visibility(mode: str) -> Dict[str, Any]:
                 """Update component visibility based on input mode."""
@@ -665,70 +569,24 @@ class TranslationApp:
                     logger.error(f"Processing error: {e}")
                     return "", f"❌ Error: {str(e)}"
             
-            def handle_translate_with_input(
+            def handle_translate(
                 extracted_text: str,
                 source_lang: str,
                 target_lang: str
-            ) -> Tuple[str, str, str]:
-                """Handle translation and return inputs for logging."""
+            ) -> str:
+                """Handle translation of processed text."""
                 if not extracted_text.strip():
-                    return "📝 No text to translate.", "", ""
+                    return "📝 No text to translate."
                 try:
-                    translated = self.translation_service.translate(
+                    return self.translation_service.translate(
                         extracted_text,
                         Language(source_lang),
                         Language(target_lang)
                     )
-                    return translated, extracted_text, source_lang
                 except Exception as e:
                     logger.error(f"Translation error: {e}")
-                    error_msg = f"❌ Translation error: {str(e)}"
-                    return error_msg, extracted_text, source_lang
-
-            def set_states_for_feedback(
-                output: str,
-                inp: str,
-                src: str,
-                tgt: str
-            ):
-                """Set hidden states for feedback submission."""
-                return inp, output, src, tgt
-
-            def save_feedback(
-                user_input: str,
-                model_output: str,
-                source_lang_str: str,
-                target_lang_str: str,
-                notation_val: float,
-                correct_trans: str
-            ):
-                """Save feedback to CSV and clear form."""
-                try:
-                    source_lang = Language(source_lang_str)
-                    target_lang = Language(target_lang_str)
-                    
-                    self.log_feedback(
-                        source_lang=source_lang,
-                        target_lang=target_lang,
-                        user_input=user_input,
-                        model_output=model_output,
-                        notation=notation_val,
-                        correct_translation=correct_trans or None
-                    )
-                    # Return values to reset UI components
-                    return (
-                        "✅ Thank you for your feedback!",
-                        None,   # reset slider
-                        ""      # clear correction box
-                    )
-                except Exception as e:
-                    logger.error(f"Feedback submission failed: {e}")
-                    return (
-                        f"❌ Failed to save feedback: {str(e)}",
-                        notation_val,   # keep value
-                        correct_trans   # keep text
-                    )
-
+                    return f"❌ Translation error: {str(e)}"
+            
             # Connect events
             input_mode.change(
                 fn=update_visibility,
@@ -736,37 +594,16 @@ class TranslationApp:
                 outputs=[input_text, audio_input, file_input, extracted_text, output_text]
             )
             
-            # Chain: Process → Translate → Store context
-            process_event = translate_btn.click(
+            translate_btn.click(
                 fn=handle_process,
                 inputs=[input_mode, input_lang, input_text, audio_input, file_input],
                 outputs=[extracted_text, output_text]
-            )
-            
-            process_event.success(
-                fn=handle_translate_with_input,
+            ).then(
+                fn=handle_translate,
                 inputs=[extracted_text, input_lang, output_lang],
-                outputs=[output_text, gr.State(), gr.State()]
-            ).success(
-                fn=set_states_for_feedback,
-                inputs=[output_text, extracted_text, input_lang, output_lang],
-                outputs=[user_input_state, model_output_state, source_lang_state, target_lang_state]
-            )
-            
-            # Feedback submission
-            submit_feedback.click(
-                fn=save_feedback,
-                inputs=[
-                    user_input_state,
-                    model_output_state,
-                    source_lang_state,
-                    target_lang_state,
-                    notation,
-                    correct_translation
-                ],
-                outputs=[feedback_status, notation, correct_translation]
+                outputs=output_text
             )
-                    
+        
         return interface
 
 # ================================