Fix audio looping and update version to 0.2.12

Updated the version number in `__init__.py` to 0.2.12.
Added a `loop` argument to `_mount_background_audio` in `audio.py`
to control audio looping, defaulting to `True`. Adjusted the
function to dynamically set or remove the `loop` attribute.
Modified `_game_over_content` in `ui.py` to play congratulations
music once by setting `loop=False`. Refactored `_render_game_over`
to separate handling of congratulations and background music,
ensuring correct looping behavior. Removed unnecessary
`remount_background_audio` logic. Updated README.md with a
changelog entry for version 0.2.12, highlighting the fix for
music looping on the congratulations screen.

README.md

@@ -106,6 +106,9 @@ docker run -p 8501:8501 battlewords
 
 ## Changelog
 
+-0.2.12
+  - fix music looping on congratulations screen
+
 -0.2.11
   - update timer to be live during gameplay, but reset with each action
   - compact design

battlewords/__init__.py

@@ -1,2 +1,2 @@
-__version__ = "0.2.11"
+__version__ = "0.2.12"
 __all__ = ["models", "generator", "logic", "ui"]

battlewords/audio.py

@@ -34,8 +34,15 @@ def _load_audio_data_url(path: str) -> str:
         encoded = base64.b64encode(fp.read()).decode("ascii")
     return f"data:{mime};base64,{encoded}"
 
-def _mount_background_audio(enabled: bool, src_data_url: Optional[str], volume: float) -> None:
-    """Create/update a single hidden <audio> element in the top page and play/pause it."""
+def _mount_background_audio(enabled: bool, src_data_url: Optional[str], volume: float, loop: bool = True) -> None:
+    """Create/update a single hidden <audio> element in the top page and play/pause it.
+
+    Args:
+        enabled: Whether the background audio should be active.
+        src_data_url: data: URL for the audio source.
+        volume: 0.0–1.0 volume level.
+        loop: Whether the audio should loop (default True).
+    """
     from streamlit.components.v1 import html as _html
 
     if not enabled or not src_data_url:
@@ -55,6 +62,8 @@ def _mount_background_audio(enabled: bool, src_data_url: Optional[str], volume:
 
     # Clamp volume
     vol = max(0.0, min(1.0, float(volume)))
+    should_loop = "true" if loop else "false"
+
     # Inject or update a single persistent audio element and make sure it starts after interaction if autoplay is blocked
     _html(
         f"""
@@ -66,10 +75,20 @@ def _mount_background_audio(enabled: bool, src_data_url: Optional[str], volume:
             audio = doc.createElement('audio');
             audio.id = 'bw-bg-audio';
             audio.style.display = 'none';
-            audio.setAttribute('loop', '');
-            audio.setAttribute('autoplay', '');
             doc.body.appendChild(audio);
           }}
+
+          // Ensure loop is explicitly set every time, even if element already exists
+          const shouldLoop = {should_loop};
+          audio.loop = shouldLoop;
+          if (shouldLoop) {{
+            audio.setAttribute('loop', '');
+          }} else {{
+            audio.removeAttribute('loop');
+          }}
+          audio.autoplay = true;
+          audio.setAttribute('autoplay', '');
+
           const newSrc = "{src_data_url}";
           if (audio.src !== newSrc) {{
             audio.src = newSrc;

battlewords/ui.py

@@ -1094,10 +1094,9 @@ def _game_over_content(state: GameState) -> None:
     congrats_music_path = os.path.join(music_dir, "congratulations.mp3")
     if os.path.exists(congrats_music_path):
         src_url = _load_audio_data_url(congrats_music_path)
-        # Play at full volume (or use previous music_volume setting)
-        _mount_background_audio(True, src_url, (st.session_state.get("music_volume", 100)) / 100)
+        # Play once (no loop) at configured volume
+        _mount_background_audio(True, src_url, (st.session_state.get("music_volume", 100)) / 100, loop=False)
     else:
-        # Fallback: keep previous music or silence
         _mount_background_audio(False, None, 0.0)
 
     # Set end_time if not already set
@@ -1208,20 +1207,25 @@ else:
             _game_over_content(state)
 
 def _render_game_over(state: GameState):
-    # Determine visibility
     visible = bool(st.session_state.get("show_gameover_overlay", True)) and is_game_over(state)
-    if not visible and st.session_state.get("remount_background_audio", False):
-        # Remount background audio when modal is dismissed (X or button)
-        music_dir = _get_music_dir()
+    music_dir = _get_music_dir()
+    if visible:
+        # Mount congratulations music (play once, do not loop)
+        congrats_music_path = os.path.join(music_dir, "congratulations.mp3")
+        if os.path.exists(congrats_music_path):
+            src_url = _load_audio_data_url(congrats_music_path)
+            _mount_background_audio(True, src_url, (st.session_state.get("music_volume", 100)) / 100, loop=False)
+        else:
+            _mount_background_audio(False, None, 0.0)
+        _game_over_dialog(state)
+    else:
+        # Mount background music (loop by default)
         background_path = os.path.join(music_dir, "background.mp3")
         if os.path.exists(background_path):
             src_url = _load_audio_data_url(background_path)
             _mount_background_audio(True, src_url, (st.session_state.get("music_volume", 100)) / 100)
         else:
             _mount_background_audio(False, None, 0.0)
-        st.session_state["remount_background_audio"] = False  # reset flag
-    if visible:
-        _game_over_dialog(state)
 
 def _sort_wordlist(filename):    
     import time  # Add this import