0.2.22

- fix challenge mode link
- challenge mode UI improvements

README.md

@@ -121,6 +121,10 @@ docker run -p8501:8501 battlewords
  - Persistent Storage: all game results saved locally for personal statistics without accounts.
  - Challenge Mode: remote storage of challenge results, multi-user leaderboard, and shareable links.
 
+-0.2.22
+ - fix challenge mode link 
+ - challenge mode UI improvements
+ 
 -0.2.21
  - fix tests 
  

battlewords/__init__.py

@@ -1,2 +1,2 @@
-__version__ = "0.2.21"
+__version__ = "0.2.22"
 __all__ = ["models", "generator", "logic", "ui", "game_storage"]

battlewords/game_storage.py

@@ -419,12 +419,14 @@ def load_game_from_sid(
         return None
 
 
-def get_shareable_url(sid: str) -> str:
+def get_shareable_url(sid: str, base_url: str = None) -> str:
     """
     Generate a shareable URL from a short ID.
+    If running locally, use localhost. Otherwise, use HuggingFace Space domain.
 
     Args:
         sid: Short ID (8 characters)
+        base_url: Optional override for the base URL (for testing or custom deployments)
 
     Returns:
         str: Full shareable URL
@@ -432,9 +434,24 @@ def get_shareable_url(sid: str) -> str:
     Example:
         >>> url = get_shareable_url("abc12345")
         >>> print(url)
-        https://Surn/BattleWords/?game_id=abc12345
+        https://surn-battlewords.hf.space/?game_id=abc12345
     """
-    return f"https://{SPACE_NAME}/?game_id={sid}"
+    import os
+    from battlewords.modules.constants import SPACE_NAME
+
+    # 1. If base_url is provided, use it directly
+    if base_url:
+        return f"{base_url.rstrip('/')}/?game_id={sid}"
+
+    # 2. Check for local development (common Streamlit env vars)
+    port = os.environ.get("PORT") or os.environ.get("STREAMLIT_SERVER_PORT") or "8501"
+    host = os.environ.get("HOST") or os.environ.get("STREAMLIT_SERVER_ADDRESS") or "localhost"
+    if host in ("localhost", "127.0.0.1") or os.environ.get("IS_LOCAL", "").lower() == "true":
+        return f"http://{host}:{port}/?game_id={sid}"
+
+    # 3. Otherwise, build HuggingFace Space URL from SPACE_NAME
+    space = (SPACE_NAME or "surn/battlewords").lower().replace("/", "-")
+    return f"https://{space}.hf.space/?game_id={sid}"
 
 
 if __name__ == "__main__":

battlewords/ui.py

@@ -495,81 +495,80 @@ def _render_header():
     st.title(f"Battlewords v{version}")
 
     st.subheader("Reveal letters in cells, then guess the words!")
-    # st.markdown(
-    #     "- Grid is 12×12 with 6 words (two 4-letter, two 5-letter, two 6-letter).\n"
-    #     "- After each reveal, you may submit one word guess below.\n"
-    #     "- Scoring: length + unrevealed letters of that word at guess time.\n"
-    #     "- Score Board: radar of last letter of word, score and status.\n"
-    #     "- Words do not overlap, but may be touching.")
-    with st.expander("🎯 Challenge Mode (click to expand/collapse)", expanded=True):
-        # Show Challenge Mode banner if loading a shared game
-        shared_settings = st.session_state.get("shared_game_settings")
-        if shared_settings:
-            users = shared_settings.get("users", [])
-
-            if users:
-                # Sort users by score (descending), then by time (ascending)
-                sorted_users = sorted(users, key=lambda u: (-u["score"], u["time"]))
-                best_user = sorted_users[0]
-                best_score = best_user["score"]
-                best_time = best_user["time"]
-                mins, secs = divmod(best_time, 60)
-                best_time_str = f"{mins:02d}:{secs:02d}"
-
-                # Build leaderboard HTML
-                leaderboard_rows = []
-                for i, user in enumerate(sorted_users[:5], 1):  # Top 5
-                    u_mins, u_secs = divmod(user["time"], 60)
-                    u_time_str = f"{u_mins:02d}:{u_secs:02d}"
-                    medal = ["🥇", "🥈", "🥉"][i-1] if i <= 3 else f"{i}."
-                    leaderboard_rows.append(
-                        f"<div style='padding:0.25rem; font-size:0.85rem;'>{medal} {user['username']}: {user['score']} pts in {u_time_str}</div>"
+
+    # Only show Challenge Mode expander if in challenge mode and game_id is present
+    params = st.query_params if hasattr(st, "query_params") else {}
+    is_challenge_mode = "shared_game_settings" in st.session_state and "game_id" in params
+
+    if is_challenge_mode:
+        with st.expander("🎯 Challenge Mode (click to expand/collapse)", expanded=True):
+            shared_settings = st.session_state.get("shared_game_settings")
+            if shared_settings:
+                users = shared_settings.get("users", [])
+
+                if users:
+                    # Sort users by score (descending), then by time (ascending)
+                    sorted_users = sorted(users, key=lambda u: (-u["score"], u["time"]))
+                    best_user = sorted_users[0]
+                    best_score = best_user["score"]
+                    best_time = best_user["time"]
+                    mins, secs = divmod(best_time, 60)
+                    best_time_str = f"{mins:02d}:{secs:02d}"
+
+                    # Build leaderboard HTML
+                    leaderboard_rows = []
+                    for i, user in enumerate(sorted_users[:5], 1):  # Top 5
+                        u_mins, u_secs = divmod(user["time"], 60)
+                        u_time_str = f"{u_mins:02d}:{u_secs:02d}"
+                        medal = ["🥇", "🥈", "🥉"][i-1] if i <= 3 else f"{i}."
+                        leaderboard_rows.append(
+                            f"<div style='padding:0.25rem; font-size:0.85rem;'>{medal} {user['username']}: {user['score']} pts in {u_time_str}</div>"
+                        )
+                    leaderboard_html = "".join(leaderboard_rows)
+
+                    st.markdown(
+                        f"""
+                        <div style="
+                            background: linear-gradient(90deg, #1d64c8 0%, #165ba8 100%);
+                            color: white;
+                            padding: 1rem;
+                            border-radius: 0.5rem;
+                            margin-bottom: 1rem;
+                            text-align: center;
+                            box-shadow: 0 4px 6px rgba(0, 0, 0, 0.1);
+                        ">
+                            🎯 <strong>CHALLENGE MODE</strong> 🎯<br/>
+                            <span style="font-size: 0.9rem;">
+                                Beat the best: <strong>{best_score} points</strong> in <strong>{best_time_str}</strong> by <strong>{best_user['username']}</strong>
+                            </span>
+                            <div style="margin-top:0.75rem; border-top: 1px solid rgba(255,255,255,0.3); padding-top:0.5rem;">
+                                <strong style="font-size:0.9rem;">🏆 Leaderboard</strong>
+                                {leaderboard_html}
+                            </div>
+                        </div>
+                        """,
+                        unsafe_allow_html=True
                     )
-                leaderboard_html = "".join(leaderboard_rows)
-
-                st.markdown(
-                    f"""
-                    <div style="
-                        background: linear-gradient(90deg, #1d64c8 0%, #165ba8 100%);
-                        color: white;
-                        padding: 1rem;
-                        border-radius: 0.5rem;
-                        margin-bottom: 1rem;
-                        text-align: center;
-                        box-shadow: 0 4px 6px rgba(0, 0, 0, 0.1);
-                    ">
-                        🎯 <strong>CHALLENGE MODE</strong> 🎯<br/>
-                        <span style="font-size: 0.9rem;">
-                            Beat the best: <strong>{best_score} points</strong> in <strong>{best_time_str}</strong> by <strong>{best_user['username']}</strong>
-                        </span>
-                        <div style="margin-top:0.75rem; border-top: 1px solid rgba(255,255,255,0.3); padding-top:0.5rem;">
-                            <strong style="font-size:0.9rem;">🏆 Leaderboard</strong>
-                            {leaderboard_html}
+                else:
+                    st.markdown(
+                        """
+                        <div style="
+                            background: linear-gradient(90deg, #1d64c8 0%, #165ba8 100%);
+                            color: white;
+                            padding: 1rem;
+                            border-radius: 0.5rem;
+                            margin-bottom: 1rem;
+                            text-align: center;
+                            box-shadow: 0 4px 6px rgba(0, 0, 0, 0.1);
+                        ">
+                            🎯 <strong>CHALLENGE MODE</strong> 🎯<br/>
+                            <span style="font-size: 0.9rem;">
+                                Be the first to complete this challenge!
+                            </span>
                         </div>
-                    </div>
-                    """,
-                    unsafe_allow_html=True
-                )
-            else:
-                st.markdown(
-                    """
-                    <div style="
-                        background: linear-gradient(90deg, #1d64c8 0%, #165ba8 100%);
-                        color: white;
-                        padding: 1rem;
-                        border-radius: 0.5rem;
-                        margin-bottom: 1rem;
-                        text-align: center;
-                        box-shadow: 0 4px 6px rgba(0, 0, 0, 0.1);
-                    ">
-                        🎯 <strong>CHALLENGE MODE</strong> 🎯<br/>
-                        <span style="font-size: 0.9rem;">
-                            Be the first to complete this challenge!
-                        </span>
-                    </div>
-                    """,
-                    unsafe_allow_html=True
-                )
+                        """,
+                        unsafe_allow_html=True
+                    )
 
     inject_styles()
 
@@ -1642,9 +1641,6 @@ def _render_game_over(state: GameState):
                     _mount_background_audio(True, src_url, (st.session_state.get("music_volume", 100)) / 100)
                 else:
                     _mount_background_audio(False, None, 0.0)
-        else:
-            # Disable all music playback
-            _mount_background_audio(False, None, 0.0)
 
 def run_app():
     # Handle query params using new API