Update app.py

app.py

@@ -3,144 +3,114 @@ from langchain_groq import ChatGroq
 import json
 import time
 
-# 🔹 Groq API Key (Replace with your actual key)
+# 🎯 API Key (Replace with your actual key)
 GROQ_API_KEY = "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"
 
-# Streamlit App Title
+# 🔹 Streamlit App Title
 st.title('🎯 AI Quiz Generator')
 st.subheader('🚀 Test Your Knowledge!')
 
-# Input Fields
+# 🔹 User Inputs
 standard = st.text_input('📚 Enter Standard/Grade')
 topic = st.text_input('📝 Enter Topic')
 
-# Quiz Type Selection
-quiz_type = st.selectbox("🎭 Select Quiz Type", ["Multiple Choice Questions (MCQ)", "True or False", "Fill in the Blanks"])
-
-# Difficulty Level Selection
+# 🔹 Difficulty Level
 difficulty = st.radio("📊 Select Difficulty Level", ["Low", "Medium", "Hard"])
 
-# Number of Questions Selection (1 to 10)
+# 🔹 Number of Questions (1-10)
 num_questions = st.slider("🔢 Select Number of Questions", min_value=1, max_value=10, value=5)
 
-# Initialize AI Model
+# 🔹 Initialize AI Model
 model = ChatGroq(
     temperature=0.6,
     groq_api_key=GROQ_API_KEY,
-    model_name="llama-3.3-70b-versatile" 
+    model_name="llama-3.3-70b-versatile"
 )
 
+def detect_quiz_type(topic):
+    """AI determines the best quiz type for the topic."""
+    prompt = f"""
+    Given the topic '{topic}', select the most suitable quiz type:
+    - 'MCQ' for subjects like Science, Math, History.
+    - 'True/False' for fact-based topics.
+    - 'Fill in the Blanks' for language-based topics.
+
+    Return only one of these: "MCQ", "True/False", "Fill in the Blanks".
+    """
+    response = model.predict(prompt).strip()
+    if response in ["MCQ", "True/False", "Fill in the Blanks"]:
+        return response
+    return "MCQ"  # Default to MCQ
+
 def generate_quiz(standard, topic, quiz_type, difficulty, num_questions):
-    """Generate quiz based on user selection and return JSON data."""
-    
-    if quiz_type == "Multiple Choice Questions (MCQ)":
-        prompt = f"""
-        Generate {num_questions} multiple choice questions (MCQs) for a {standard} student on {topic}. 
-        Each question should have exactly 4 options (A, B, C, D) and one correct answer.
-        Return the result strictly in the following JSON format:
-        {{
-            "questions": [
-                {{"question": "Question text", "options": ["A) Option 1", "B) Option 2", "C) Option 3", "D) Option 4"], "answer": "A) Option"}}
-            ]
-        }}
-        """
-    elif quiz_type == "True or False":
-        prompt = f"""
-        Generate {num_questions} True or False questions for a {standard} student on {topic}.
-        Return the result in strict JSON format:
-        {{
-            "questions": [
-                {{"question": "Question text", "answer": "True or False"}}
-            ]
-        }}
-        """
-    else:  # Fill in the Blanks
-        prompt = f"""
-        Generate {num_questions} fill-in-the-blank questions for a {standard} student on {topic}.
-        Provide correct answers in JSON format:
-        {{
-            "questions": [
-                {{"question": "Question with __ blank", "answer": "Correct Answer"}}
-            ]
-        }}
-        """
+    """Generate quiz using AI with strict JSON formatting."""
+    prompt = f"""
+    Generate {num_questions} {quiz_type} questions for a {standard} student on {topic}. 
 
-    try:
-        response = model.predict(prompt).strip()  # Ensure clean output
+    Format:
+    {{"questions": [
+        {{"question": "Example?", "options": ["A) Option1", "B) Option2"], "answer": "A) Option1"}} 
+    ]}}
+    """
 
-        # Validate if response is in JSON format
+    try:
+        response = model.predict(prompt).strip()
         quiz_data = json.loads(response)
-        if "questions" in quiz_data:
-            return quiz_data
-        else:
-            st.error("⚠️ The AI did not return a valid quiz format.")
-            return None
+        return quiz_data if "questions" in quiz_data else None
     except json.JSONDecodeError:
-        st.error("⚠️ Failed to generate quiz. The AI did not return a proper JSON response.")
-        return None
-    except Exception as e:
-        st.error(f"⚠️ Error: {str(e)}")
+        st.error("⚠️ AI response is not valid JSON. Try again!")
         return None
 
-
 def normalize_answer(answer):
-    """Convert answers to a standard format for comparison."""
-    answer = answer.strip().lower()
-    if ") " in answer:  # Handles cases like "A) Football"
-        answer = answer.split(") ")[0]  # Keep only "A", "B", etc.
-    return answer
+    """Standardize answers for case-insensitive comparison."""
+    return answer.strip().lower()
 
 def calculate_score(user_answers, correct_answers):
-    """Calculate score and return details of correct and incorrect answers."""
-    results = []
-    score = 0
-
+    """Calculate quiz score and return result details."""
+    results, score = [], 0
     for q, user_ans in user_answers.items():
         correct_ans = normalize_answer(correct_answers.get(q, ""))
         user_ans = normalize_answer(user_ans)
-
         is_correct = user_ans == correct_ans
         results.append((q, user_ans, correct_ans, is_correct))
         if is_correct:
             score += 1
-
     return score, results
 
-# Session state to store quiz data
+# 🔹 Store Quiz Data in Session
 if 'quiz_data' not in st.session_state:
     st.session_state.quiz_data = None
 if 'user_answers' not in st.session_state:
     st.session_state.user_answers = {}
 
-# Generate Quiz Button
+# 🔹 Generate Quiz Button
 if st.button("🚀 Generate Quiz"):
     if standard and topic:
-        st.session_state.quiz_data = generate_quiz(standard, topic, quiz_type, difficulty, num_questions)
+        auto_quiz_type = detect_quiz_type(topic)  # AI selects quiz type
+        st.session_state.quiz_data = generate_quiz(standard, topic, auto_quiz_type, difficulty, num_questions)
         if st.session_state.quiz_data:
-            st.session_state.user_answers = {}  # Reset answers
-            st.success(f"{quiz_type} Quiz Generated with {num_questions} Questions! 🎉")
-            st.balloons()  # 🎈 Balloons for generating the quiz
+            st.session_state.user_answers = {}  
+            st.success(f"✅ {auto_quiz_type} Quiz Generated on '{topic}' with {num_questions} Questions!")
+            st.balloons()
     else:
         st.error("⚠️ Please enter both the standard and topic.")
 
-# Display Quiz if Available
+# 🔹 Display Quiz if Available
 if st.session_state.quiz_data:
     st.write("### 📝 Quiz Questions:")
     questions = st.session_state.quiz_data.get("questions", [])
 
-    for i, q in enumerate(questions):  # Display all selected questions
+    for i, q in enumerate(questions):
         st.write(f"**Q{i+1}: {q['question']}**")
 
-        if quiz_type == "Multiple Choice Questions (MCQ)":
+        if "options" in q:  
             user_answer = st.radio(f"🧐 Select your answer for Question {i+1}", options=q["options"], key=f"question_{i+1}")
-        elif quiz_type == "True or False":
-            user_answer = st.radio(f"🧐 Select your answer for Question {i+1}", options=["True", "False"], key=f"question_{i+1}")
-        else:  # Fill in the Blanks
+        else:  
             user_answer = st.text_input(f"🧐 Your answer for Question {i+1}", key=f"question_{i+1}")
 
         st.session_state.user_answers[f"question_{i+1}"] = user_answer
 
-# Submit Quiz Button
+# 🔹 Submit Quiz Button
 if st.button("✅ Submit Quiz"):
     if st.session_state.quiz_data:
         correct_answers = {f"question_{i+1}": q["answer"].strip().lower() for i, q in enumerate(st.session_state.quiz_data["questions"])}
@@ -149,7 +119,7 @@ if st.button("✅ Submit Quiz"):
         st.write("### 🎯 Quiz Results")
         st.write(f"Your Score: **{score}/{num_questions}** 🎉")
 
-        # Display Correct Answers
+        # 🔹 Show Correct/Incorrect Answers
         for q_id, user_ans, correct_ans, is_correct in results:
             question_num = q_id.replace("question_", "Question ")
             if is_correct:
@@ -157,10 +127,10 @@ if st.button("✅ Submit Quiz"):
             else:
                 st.error(f"❌ {question_num} - Incorrect! Your Answer: {user_ans.upper()} | Correct Answer: {correct_ans.upper()}")
 
-        # 🎉 Animations based on score
-        time.sleep(1)  # Small delay for better effect
+        # 🔹 Animations Based on Score
+        time.sleep(1)  
         if score == num_questions:
-            st.snow()  # 🏆 Trophy effect for a perfect score
+            st.snow()  
             st.success("🏆 Perfect Score! You are a genius! 🚀")
         elif score / num_questions >= 0.7:
             st.success("🎉 Great job! Keep practicing!")
@@ -170,3 +140,4 @@ if st.button("✅ Submit Quiz"):
     else:
         st.error("⚠️ Quiz data not available. Please regenerate the quiz.")
 
+