Update models/suggestion.py

models/suggestion.py

@@ -14,9 +14,9 @@ class RecommendationType(str, Enum):
 
 
 class TakeProfitPoints(BaseModel):
-    first: float
-    second: float
-    third: float
+    first: float = Field(..., description="First take profit")
+    second: float = Field(..., description="Second take profit")
+    third: float = Field(..., description="Third take profit")
 
 
 class TradeSuggestion(BaseModel):
@@ -30,21 +30,28 @@ class TradeSuggestion(BaseModel):
     trade_amount: float
 
     @property
-    def potential_profit_percentage(self):
+    def is_entry_better_than_current(self) -> bool:
+        return (
+            self.entry_price <= self.current_price
+            if self.direction == TradeDirection.LONG
+            else self.entry_price >= self.current_price
+        )
+
+    @property
+    def potential_profit_percentage(self) -> float:
         if self.direction == TradeDirection.LONG:
             return (
                 ((self.take_profit.third - self.entry_price) / self.entry_price)
                 * 100
                 * self.recommended_leverage
             )
-        else:
-            return (
-                ((self.entry_price - self.take_profit.third) / self.entry_price)
-                * 100
-                * self.recommended_leverage
-            )
+        return (
+            ((self.entry_price - self.take_profit.third) / self.entry_price)
+            * 100
+            * self.recommended_leverage
+        )
 
-    def to_prompt_dict(self):
+    def to_prompt_dict(self) -> dict:
         return {
             "symbol": self.symbol,
             "direction": self.direction.value,