some code optimization

app.py

@@ -507,40 +507,17 @@ with gr.Blocks(title="Model Test Results Dashboard", css=load_css(), js=js_func)
     def handle_summary_click(history_mode: bool):
         description = get_description_text()
         links = get_ci_links()
-        fr_plot, amd_plot, nvidia_plot = get_historical_summary_plots()
         if history_mode:
-            return (
-                description,
-                links,
-                gr.update(visible=False),  # current_view
-                gr.update(visible=True),   # historical_view
-                gr.update(visible=False),  # summary_view
-                gr.update(visible=False),  # summary_display
-                gr.update(visible=False),  # detail_view
-                fr_plot,
-                amd_plot,
-                nvidia_plot,
-                gr.update(visible=False),  # time_series_detail_view
-                False,                     # in_model_view_state
-                "",                        # selected_model_state (clear it)
-            )
+            fr_plot, amd_plot, nvidia_plot = get_historical_summary_plots()
+            return (description, links, gr.update(visible=False), gr.update(visible=True), 
+                    gr.update(visible=False), gr.update(visible=False), gr.update(visible=False),
+                    fr_plot, amd_plot, nvidia_plot, gr.update(visible=False), False, "")
         else:
             fig = create_summary_page(Ci_results.df, Ci_results.available_models)
-            return (
-                description,
-                links,
-                gr.update(visible=True),   # current_view
-                gr.update(visible=False),  # historical_view
-                gr.update(visible=True),   # summary_view
-                gr.update(value=fig, visible=True), # summary_display
-                gr.update(visible=False),  # detail_view
-                gr.update(visible=False),  # time_series_failure_rates
-                gr.update(visible=False),  # time_series_amd_tests
-                gr.update(visible=False),  # time_series_nvidia_tests
-                gr.update(visible=False),  # time_series_detail_view
-                False,                     # in_model_view_state
-                "",                        # selected_model_state (clear it)
-            )
+            return (description, links, gr.update(visible=True), gr.update(visible=False),
+                    gr.update(visible=True), gr.update(value=fig, visible=True), gr.update(visible=False),
+                    gr.update(visible=False), gr.update(visible=False), gr.update(visible=False),
+                    gr.update(visible=False), False, "")
 
     summary_button.click(
         fn=handle_summary_click,
@@ -643,86 +620,30 @@ with gr.Blocks(title="Model Test Results Dashboard", css=load_css(), js=js_func)
         )
     
     def handle_history_toggle(history_mode, last_selected_model, in_model_view):
+        # Helper to create visibility updates efficiently
+        hidden = gr.update(visible=False)
+        shown = gr.update(visible=True)
+        noop = gr.update()
+        
         if history_mode:
-            # If currently in model view and valid model, show historical model detail
-            if in_model_view and last_selected_model:
+            if in_model_view and last_selected_model:  # Show historical model detail
                 amd_ts, nvidia_ts = show_time_series_model(last_selected_model)
-                return (
-                    gr.update(visible=False),   # current_view
-                    gr.update(visible=True),    # historical_view
-                    gr.update(visible=False),   # summary_view
-                    gr.update(visible=False),   # summary_display
-                    gr.update(visible=False),   # detail_view
-                    gr.update(visible=False),   # time_series_failure_rates
-                    gr.update(visible=False),   # time_series_amd_tests
-                    gr.update(visible=False),   # time_series_nvidia_tests
-                    amd_ts,                     # time_series_amd_model_plot
-                    nvidia_ts,                  # time_series_nvidia_model_plot
-                    gr.update(visible=True),    # time_series_detail_view
-                    gr.update(),                # plot_output
-                    gr.update(),                # amd_failed_tests_output
-                    gr.update(),                # nvidia_failed_tests_output
-                    True,                       # in_model_view_state (still in model view)
-                )
-            # Otherwise show historical summary
+                return (hidden, shown, hidden, hidden, hidden, hidden, hidden, hidden, 
+                        amd_ts, nvidia_ts, shown, noop, noop, noop, True)
+            # Show historical summary
             fr_plot, amd_plot, nvidia_plot = get_historical_summary_plots()
-            return (
-                gr.update(visible=False),   # current_view
-                gr.update(visible=True),    # historical_view
-                gr.update(visible=False),   # summary_view
-                gr.update(visible=False),   # summary_display
-                gr.update(visible=False),   # detail_view
-                fr_plot,                    # time_series_failure_rates (value + keep visibility)
-                amd_plot,                   # time_series_amd_tests
-                nvidia_plot,                # time_series_nvidia_tests
-                gr.update(),                # time_series_amd_model_plot
-                gr.update(),                # time_series_nvidia_model_plot
-                gr.update(visible=False),   # time_series_detail_view
-                gr.update(),                # plot_output
-                gr.update(),                # amd_failed_tests_output
-                gr.update(),                # nvidia_failed_tests_output
-                False,                      # in_model_view_state
-            )
+            return (hidden, shown, hidden, hidden, hidden, fr_plot, amd_plot, nvidia_plot,
+                    noop, noop, hidden, noop, noop, noop, False)
         else:
-            # Switch to current mode: show model if selected; otherwise summary
+            # Switch to current mode
             if last_selected_model and Ci_results.df is not None and not Ci_results.df.empty and last_selected_model in Ci_results.df.index:
                 fig, amd_txt, nvidia_txt = plot_model_stats(Ci_results.df, last_selected_model, Ci_results.all_historical_data)
-                return (
-                    gr.update(visible=True),    # current_view
-                    gr.update(visible=False),   # historical_view
-                    gr.update(visible=False),   # summary_view
-                    gr.update(visible=False),   # summary_display
-                    gr.update(visible=True),    # detail_view
-                    gr.update(visible=False),   # time_series_failure_rates
-                    gr.update(visible=False),   # time_series_amd_tests
-                    gr.update(visible=False),   # time_series_nvidia_tests
-                    gr.update(),                # time_series_amd_model_plot
-                    gr.update(),                # time_series_nvidia_model_plot
-                    gr.update(visible=False),   # time_series_detail_view
-                    fig,                        # plot_output
-                    amd_txt,                    # amd_failed_tests_output
-                    nvidia_txt,                 # nvidia_failed_tests_output
-                    True,                       # in_model_view_state
-                )
+                return (shown, hidden, hidden, hidden, shown, hidden, hidden, hidden,
+                        noop, noop, hidden, fig, amd_txt, nvidia_txt, True)
             else:
                 fig = create_summary_page(Ci_results.df, Ci_results.available_models)
-                return (
-                    gr.update(visible=True),    # current_view
-                    gr.update(visible=False),   # historical_view
-                    gr.update(visible=True),    # summary_view
-                    gr.update(value=fig, visible=True),  # summary_display
-                    gr.update(visible=False),   # detail_view
-                    gr.update(visible=False),   # time_series_failure_rates
-                    gr.update(visible=False),   # time_series_amd_tests
-                    gr.update(visible=False),   # time_series_nvidia_tests
-                    gr.update(),                # time_series_amd_model_plot
-                    gr.update(),                # time_series_nvidia_model_plot
-                    gr.update(visible=False),   # time_series_detail_view
-                    gr.update(),                # plot_output
-                    gr.update(),                # amd_failed_tests_output
-                    gr.update(),                # nvidia_failed_tests_output
-                    False,                      # in_model_view_state
-                )
+                return (shown, hidden, shown, gr.update(value=fig, visible=True), hidden,
+                        hidden, hidden, hidden, noop, noop, hidden, noop, noop, noop, False)
 
     history_view_button.change(
         fn=handle_history_toggle,
@@ -758,67 +679,32 @@ with gr.Blocks(title="Model Test Results Dashboard", css=load_css(), js=js_func)
 
     # Unified model click handler: respects History toggle
     def handle_model_click(selected_model: str, history_mode: bool):
+        noop, hidden, shown = gr.update(), gr.update(visible=False), gr.update(visible=True)
         if history_mode:
             amd_ts, nvidia_ts = show_time_series_model(selected_model)
-            return (
-                gr.update(),                 # plot_output
-                gr.update(),                 # amd_failed_tests_output
-                gr.update(),                 # nvidia_failed_tests_output
-                gr.update(visible=False),    # current_view
-                gr.update(visible=True),     # historical_view
-                gr.update(visible=False),    # summary_view
-                gr.update(visible=False),    # summary_display
-                gr.update(visible=False),    # detail_view
-                gr.update(visible=False),    # time_series_failure_rates
-                gr.update(visible=False),    # time_series_amd_tests
-                gr.update(visible=False),    # time_series_nvidia_tests
-                amd_ts,                      # time_series_amd_model_plot
-                nvidia_ts,                   # time_series_nvidia_model_plot
-                gr.update(visible=True),     # time_series_detail_view
-            selected_model, True)            # selected_model_state, in_model_view_state
+            return (noop, noop, noop, hidden, shown, hidden, hidden, hidden, hidden, hidden, 
+                    hidden, amd_ts, nvidia_ts, shown, selected_model, True)
         else:
             fig, amd_txt, nvidia_txt = plot_model_stats(Ci_results.df, selected_model, Ci_results.all_historical_data)
-            return (
-                fig,
-                amd_txt,
-                nvidia_txt,
-                gr.update(visible=True),     # current_view
-                gr.update(visible=False),    # historical_view
-                gr.update(visible=False),    # summary_view
-                gr.update(visible=False),    # summary_display
-                gr.update(visible=True),     # detail_view
-                gr.update(),                 # time_series_failure_rates
-                gr.update(),                 # time_series_amd_tests
-                gr.update(),                 # time_series_nvidia_tests
-                gr.update(),                 # time_series_amd_model_plot
-                gr.update(),                 # time_series_nvidia_model_plot
-                gr.update(visible=False),    # time_series_detail_view
-            selected_model, True)            # selected_model_state, in_model_view_state
-
+            return (fig, amd_txt, nvidia_txt, shown, hidden, hidden, hidden, shown, noop, noop,
+                    noop, noop, noop, hidden, selected_model, True)
+
+    # Define common outputs for model click handlers
+    model_click_outputs = [
+        plot_output, amd_failed_tests_output, nvidia_failed_tests_output,
+        current_view, historical_view, summary_view, summary_display, detail_view,
+        time_series_failure_rates, time_series_amd_tests, time_series_nvidia_tests,
+        time_series_amd_model_plot, time_series_nvidia_model_plot, time_series_detail_view,
+        selected_model_state, in_model_view_state,
+    ]
+    
     # Wire up all model buttons
     for i, btn in enumerate(model_buttons):
         model_name = model_choices[i]
         btn.click(
             fn=lambda history_mode, m=model_name: handle_model_click(m, history_mode),
             inputs=[history_view_button],
-            outputs=[
-                plot_output,
-                amd_failed_tests_output,
-                nvidia_failed_tests_output,
-                current_view,
-                historical_view,
-                summary_view,
-                summary_display,
-                detail_view,
-                time_series_failure_rates,
-                time_series_amd_tests,
-                time_series_nvidia_tests,
-                time_series_amd_model_plot,
-                time_series_nvidia_model_plot,
-                time_series_detail_view,
-                selected_model_state,
-                in_model_view_state,
-            ],
+            outputs=model_click_outputs,
         )
     
     # Wire up AMD failing model buttons
@@ -828,24 +714,7 @@ with gr.Blocks(title="Model Test Results Dashboard", css=load_css(), js=js_func)
         btn.click(
             fn=lambda history_mode, m=model_name: handle_model_click(m, history_mode),
             inputs=[history_view_button],
-            outputs=[
-                plot_output,
-                amd_failed_tests_output,
-                nvidia_failed_tests_output,
-                current_view,
-                historical_view,
-                summary_view,
-                summary_display,
-                detail_view,
-                time_series_failure_rates,
-                time_series_amd_tests,
-                time_series_nvidia_tests,
-                time_series_amd_model_plot,
-                time_series_nvidia_model_plot,
-                time_series_detail_view,
-                selected_model_state,
-                in_model_view_state,
-            ],
+            outputs=model_click_outputs,
         )
     
     # Wire up NVIDIA failing model buttons
@@ -855,24 +724,7 @@ with gr.Blocks(title="Model Test Results Dashboard", css=load_css(), js=js_func)
         btn.click(
             fn=lambda history_mode, m=model_name: handle_model_click(m, history_mode),
             inputs=[history_view_button],
-            outputs=[
-                plot_output,
-                amd_failed_tests_output,
-                nvidia_failed_tests_output,
-                current_view,
-                historical_view,
-                summary_view,
-                summary_display,
-                detail_view,
-                time_series_failure_rates,
-                time_series_amd_tests,
-                time_series_nvidia_tests,
-                time_series_amd_model_plot,
-                time_series_nvidia_model_plot,
-                time_series_detail_view,
-                selected_model_state,
-                in_model_view_state,
-            ],
+            outputs=model_click_outputs,
         )
     
     # Wire up both failures model buttons
@@ -882,24 +734,7 @@ with gr.Blocks(title="Model Test Results Dashboard", css=load_css(), js=js_func)
         btn.click(
             fn=lambda history_mode, m=model_name: handle_model_click(m, history_mode),
             inputs=[history_view_button],
-            outputs=[
-                plot_output,
-                amd_failed_tests_output,
-                nvidia_failed_tests_output,
-                current_view,
-                historical_view,
-                summary_view,
-                summary_display,
-                detail_view,
-                time_series_failure_rates,
-                time_series_amd_tests,
-                time_series_nvidia_tests,
-                time_series_amd_model_plot,
-                time_series_nvidia_model_plot,
-                time_series_detail_view,
-                selected_model_state,
-                in_model_view_state,
-            ],
+            outputs=model_click_outputs,
         )
 
     # Summary button click handler

model_page.py

@@ -1,19 +1,13 @@
 import matplotlib.pyplot as plt
 import pandas as pd
-from utils import generate_underlined_line
+from utils import generate_underlined_line, COLORS
 from data import extract_model_data, find_failure_first_seen
 
 # Figure dimensions
 FIGURE_WIDTH_DUAL = 18
 FIGURE_HEIGHT_DUAL = 9
 
-# Colors
-COLORS = {
-    'passed': '#4CAF50',    # Medium green
-    'failed': '#E53E3E',    # More red
-    'skipped': '#FFD54F',   # Medium yellow
-    'error': '#8B0000'      # Dark red
-}
+# Colors imported from utils
 
 # Styling constants
 BLACK = '#000000'

summary_page.py

@@ -1,6 +1,7 @@
 import matplotlib.pyplot as plt
 import pandas as pd
 from data import extract_model_data
+from utils import COLORS
 
 # Layout parameters
 COLUMNS = 3
@@ -22,14 +23,7 @@ VERTICAL_SPACING_RATIO = 0.2
 AMD_BAR_OFFSET = 0.25
 NVIDIA_BAR_OFFSET = 0.54
 
-# Colors
-COLORS = {
-    'passed': '#4CAF50',
-    'failed': '#E53E3E',
-    'skipped': '#FFD54F',
-    'error': '#8B0000',
-    'empty': "#5B5B5B"
-}
+# Colors imported from utils
 
 # Font styling
 MODEL_NAME_FONT_SIZE = 16

time_series_gradio.py

@@ -2,19 +2,11 @@ import pandas as pd
 import numpy as np
 from datetime import datetime
 from data import extract_model_data
+from utils import COLORS
 import gradio as gr
 import plotly.express as px
 import plotly.graph_objects as go
 
-COLORS = {
-    'passed': '#4CAF50',
-    'failed': '#E53E3E',
-    'skipped': '#FFD54F',
-    'error': '#8B0000',
-    'amd': '#ED1C24',
-    'nvidia': '#76B900'
-}
-
 def get_time_series_summary_dfs(historical_df: pd.DataFrame) -> dict:
     daily_stats = []
     dates = sorted(historical_df['date'].unique())

utils.py

@@ -49,3 +49,15 @@ logger = setup_logger()
 
 def generate_underlined_line(text: str) -> str:
     return text + "\n" + "─" * len(text)
+
+
+# Shared color scheme across all visualization modules
+COLORS = {
+    'passed': '#4CAF50',
+    'failed': '#E53E3E',
+    'skipped': '#FFD54F',
+    'error': '#8B0000',
+    'empty': '#5B5B5B',
+    'amd': '#ED1C24',
+    'nvidia': '#76B900'
+}