one fucntion for has_failures

app.py

@@ -35,58 +35,25 @@ Ci_results.schedule_data_reload()
 
 
 # Function to check if a model has failures
-def model_has_failures(model_name):
-    """Check if a model has any failures (AMD or NVIDIA)."""
+def model_has_failures_by_device(model_name, device='both'):
     if Ci_results.df is None or Ci_results.df.empty:
         return False
     
-    # Normalize model name to match DataFrame index
     model_name_lower = model_name.lower()
-    
-    # Check if model exists in DataFrame
     if model_name_lower not in Ci_results.df.index:
         return False
-    row = Ci_results.df.loc[model_name_lower]
-    
-    # Check for failures in both AMD and NVIDIA
-    amd_multi_failures = row.get('failed_multi_no_amd', 0)
-    amd_single_failures = row.get('failed_single_no_amd', 0)
-    nvidia_multi_failures = row.get('failed_multi_no_nvidia', 0)
-    nvidia_single_failures = row.get('failed_single_no_nvidia', 0)
-    return any([
-        amd_multi_failures > 0,
-        amd_single_failures > 0,
-        nvidia_multi_failures > 0,
-        nvidia_single_failures > 0,
-    ])
-
-def model_has_amd_failures(model_name):
-    """Check if a model has AMD failures."""
-    if Ci_results.df is None or Ci_results.df.empty:
-        return False
     
-    model_name_lower = model_name.lower()
-    if model_name_lower not in Ci_results.df.index:
-        return False
     row = Ci_results.df.loc[model_name_lower]
     
-    amd_multi_failures = row.get('failed_multi_no_amd', 0)
-    amd_single_failures = row.get('failed_single_no_amd', 0)
-    return amd_multi_failures > 0 or amd_single_failures > 0
-
-def model_has_nvidia_failures(model_name):
-    """Check if a model has NVIDIA failures."""
-    if Ci_results.df is None or Ci_results.df.empty:
-        return False
+    if device in ('amd', 'both'):
+        if row.get('failed_multi_no_amd', 0) > 0 or row.get('failed_single_no_amd', 0) > 0:
+            return True
     
-    model_name_lower = model_name.lower()
-    if model_name_lower not in Ci_results.df.index:
-        return False
-    row = Ci_results.df.loc[model_name_lower]
+    if device in ('nvidia', 'both'):
+        if row.get('failed_multi_no_nvidia', 0) > 0 or row.get('failed_single_no_nvidia', 0) > 0:
+            return True
     
-    nvidia_multi_failures = row.get('failed_multi_no_nvidia', 0)
-    nvidia_single_failures = row.get('failed_single_no_nvidia', 0)
-    return nvidia_multi_failures > 0 or nvidia_single_failures > 0
+    return False
 
 
 # Function to get current description text
@@ -232,8 +199,8 @@ with gr.Blocks(title="Model Test Results Dashboard", css=load_css(), js=js_func)
                 print(f"Creating {len(model_choices)} model buttons: {model_choices}")
 
                 for model_name in model_choices:
-                    has_amd = model_has_amd_failures(model_name)
-                    has_nvidia = model_has_nvidia_failures(model_name)
+                    has_amd = model_has_failures_by_device(model_name, 'amd')
+                    has_nvidia = model_has_failures_by_device(model_name, 'nvidia')
                     
                     if has_amd and has_nvidia:
                         both_failing_models.append(model_name)
@@ -247,7 +214,7 @@ with gr.Blocks(title="Model Test Results Dashboard", css=load_css(), js=js_func)
                 # Container for all models (visible by default)
                 with gr.Column(visible=True, elem_classes=["all-models-container"]) as all_models_container:
                     for model_name in model_choices:
-                        has_failures = model_has_failures(model_name)
+                        has_failures = model_has_failures_by_device(model_name, 'both')
                         button_classes = ["model-button"]
                         if has_failures:
                             button_classes.append("model-button-failed")